search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Remove Pipe.isCurrentlyClicked? #302

Closed jessegreenberg closed 1 week ago

jessegreenberg commented 2 weeks ago

Can this Property be removed? If not, why is it needed in addition to pipesOpenProperty?

For #270.

jessegreenberg commented 2 weeks ago

The only usage is in PipeNode, it is toggled to true/false but I don't see any listeners on it.

      pipe.isCurrentlyClickedProperty.set( true );
      pipe.isCurrentlyClickedProperty.set( false );
marlitas commented 1 week ago

Hmmm. I have a feeling this is very vestigial. Perhaps when you could individually open and close pipes? I think it can definitely be removed. This was straightforward, doesn't need review.