search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Move CrossFadeSoundClip to tambo? #303

Closed jessegreenberg closed 2 months ago

jessegreenberg commented 3 months ago

This class seems generalized and useful as a common code component, is it a good candidate for moving to tambo?

For #270.

jbphet commented 2 months ago

@jessegreenberg's suggestion seemed like a good one, so I've moved CrossFadeSoundClip to tambo and made it a big more general. The biggest change was to make it take a Property instead of a fixed value for the cross-fade amount, since this seems like something future developers would likely need.

Assigning to @marlitas for review.

marlitas commented 2 months ago

This looks nice @jbphet. There is one typo that I fixed above.

I think it's probably too late now, but it would have been nice to preserve the git history of CrossFadeSoundClip by using copy-history-to-different-repo

I think this is ready to close!