search

phetsims / mean-share-and-balance

"Mean: Share and Balance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 1 forks source link

Can BalancePointScreenView use msabSetPDOMOrder? #304

Closed jessegreenberg closed 1 week ago

jessegreenberg commented 2 weeks ago

Then all screen views would go through this, which would be nice. If not, can you add a line to BalancePointScreenView that describes this (around where the pdom orders are set)?

For #270.

marlitas commented 1 week ago

Unfortunately BalancePointScreenView must extend SoccerCommonScreenView in order to take advantage of that common code which is why it doesn't have access to msabSetPDOMOrder.

I added documentation to describe that. @jessegreenberg can you review?

jessegreenberg commented 1 week ago

I understand now, thanks! That is great documentation. Closing.