Add support for dynamic locale

phetsims / models-of-the-hydrogen-atom

"Models of the Hydrogen Atom" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.

GNU General Public License v3.0

2 stars 3 forks source link

Add support for dynamic locale #39

Closed pixelzoom closed 2 months ago

pixelzoom commented 2 years ago

[x] use Property instead of string for translated strings
[x] add "supportsDynamicLocale": true to package.json and run grunt modulify
[x] address dynamic layout problems

pixelzoom commented 2 years ago

I've done the first parts of this. But I'm blocked on addressing layout issues until I can identify those issues, which requires https://github.com/phetsims/chipper/issues/1319 to be addressed. So I'll come back to this.

pixelzoom commented 2 months ago

I tested this sim with ?stringTest=dynamic and corrected a few minor issues in the above commits. It is otherwise well-behaved. Since new development is supposed to support dynamic layout, I see no reason to keep this issue open.