search

phetsims / models-of-the-hydrogen-atom

"Models of the Hydrogen Atom" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
2 stars 3 forks source link

Change description for Light Source. #76

Open pixelzoom opened 1 day ago

pixelzoom commented 1 day ago

In https://github.com/phetsims/models-of-the-hydrogen-atom/issues/67#issuecomment-2460594348, @terracoda said:

The Light Source interaction is not being communicated as an on/off switch like in Molecules and Light. Are they not the same component?

They are not the same component. MOTHA uses scenery-phet's LaserPointerNode, which can be configured to use a RoundStickyToggleButton or RoundMomentaryButton. MAL has its own sim-specific component (no common code) called PhotonEmitterNode. It does some configuration of ARIA-related attributes, but I can't tell why or what parts are relevant for MOTHA -- there are no details in the code comments, and I can find no paper trail for the description design.

Also note that @jessegreenberg and I did considerable work on LaserPointerNode in https://github.com/phetsims/scenery-phet/issues/877. That work was informed by the requirements provided by the description designers in our 10/15/2 MOTHA meeting. If something different is desired, then that issue should be reopened, and a general solution (based on MAL PhotonEmitterNode?) implemented in LaserPointerNode.

kathy-phet commented 10 hours ago

Initially, this looks like the common code RoundStickyToggleButton needs @jessegreenberg to work at the lower level scenery piece so the pdom implementation is appropriate for a sticky toggle kind of button.

pixelzoom commented 9 hours ago

11/7/24 design meeting: @DianaTavares @arouinfar @kathy-phet @terracoda @LindaStegemann @ariel-phet @KatieWoe @pixelzoom

@jessegreenberg will work on this. Likely down in RoundStickyToggleButton. Should probably be aria-role='switch'.