phetsims / models-of-the-hydrogen-atom

"Models of the Hydrogen Atom" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
2 stars 3 forks source link

Add description for "Absorption and Emission" dialog content. #79

Closed pixelzoom closed 2 weeks ago

pixelzoom commented 2 weeks ago

In https://github.com/phetsims/models-of-the-hydrogen-atom/issues/67#issuecomment-2460594348, @terracoda asked:

How difficult is it to put the static content of the dialog in the sim, assuming the content is static? Are the different symbols different types of photons?

Quite difficult. The static content is a large collection of buttons and text, and there’s no framework for coalescing that into “static content”. I suspect that this woud be several hours of design and implementation work, involving multiple people.

@kathy-phet do you want to pursue this?

kathy-phet commented 2 weeks ago

Putting all of this information in is beyond the scope for MOTHA, but @jessegreenberg was going to update the Dialog API for sim-devs to have some options:

Another option would be to have an option to pass a simplified description of what is shown in the dialog and this option seems like a good tier 1 option to have for complex dialogs. An optional string to pass in ... should not be called accessible name, since its the content not the name. Since this is passing a Node, maybe it is an option that lives on the general Node common component?

pixelzoom commented 2 weeks ago

11/7/24 design meeting: @DianaTavares @arouinfar @kathy-phet @terracoda @LindaStegemann @ariel-phet @KatieWoe @pixelzoom

@pixelzoom will add helpText for the "Absorption and Emission" dialog (which is actually a Panel):

helpText: 'Use the buttons to set the light source to a specific wavelength.'

@jessegreenberg Will make the default for Panel to put helpText before content.

pixelzoom commented 2 weeks ago

Help text was added, shown below in A11y View.

Over to @jessegreenberg to put helpText before content as the default for Panel.

screenshot_3587
jessegreenberg commented 2 weeks ago

This was done in https://github.com/phetsims/sun/issues/912.

pixelzoom commented 2 weeks ago

Tested MOTHA in A11y View, looks great - thanks @jessegreenberg!