[ ] Naming for Property values: All AXON/Property instances should be declared with the suffix Property. For example, if a visible property is added, it should have the name visibleProperty instead of simply visible. This will help to avoid confusion with non-Property definitions.
In MolarityScreenView:
// Determines whether qualitative or quantitative a11y descriptions are used.
const useQuantitativeDescriptions = new DerivedProperty( [ valuesVisibleProperty ], () => {
return valuesVisibleProperty.value;
} );
This should be named useQuantitativeDescriptionsProperty. By convention, a Property is always named with a "Property" suffix.
This name also needs to be fixed in MolarityScreenSummaryNode and *Describer classes.
From the code-review checklist:
In MolarityScreenView:
This should be named
useQuantitativeDescriptionsProperty
. By convention, a Property is always named with a "Property" suffix.This name also needs to be fixed in MolarityScreenSummaryNode and *Describer classes.