Closed Matthew-Moore240 closed 5 years ago
@Matthew-phet, is there a reason why you moved the color parameter into a bullet of it's own? I personally think it is best to keep the list of details as short as possible, but if you move color into a bullet, you also need to move the verb, so the first bullet becomes:
I'm going to work out the same scenarios for Drink Mix in the design doc.
@Matthew-phet, as you know I have 4 drink mix examples in the design doc. I think we will refine a couple things in your examples next.
Quick question about this: I'm noticing that most of the bullet points grammatically don't make sense with the start of the sentence being "The solution is:"
Is there a different way you'd like to start this list of properties, @Matthew-phet?
@twant, @Matthew-phet and I had not finished cleaning up the examples in the design doc (sorry).
I am going to remake the potassium permanganate example, so it is in the same format as the drink mix example, then @Matthew-phet can make sure it is what he wants (what we agreed on).
@Matthew-phet, @emily-phet and @twant, I made a new set of examples for the Potassium Permanganate in the same format as the set I made for the Drink Mix solute.
@Matthew-phet, could you review both sets.
I made some suggested changes to the scales (last week) which I don't think we have discussed.
In addition, while I was adjusting the Potassium Permanganate examples, I came up with possible new phrasing for the bullet item containing the description of the concentration read out range. And in so doing, I now realize why I was so uncomfortable with the description of the read out. If we include it, we are basically describing concentration twice.
I am fine going with your plan (and describing the exact read out range), but I have also included my alternatives that we could discuss tomorrow if you are available, or Tuesday in our regular meeting.
You'll see that the suggested new phrasing has some challenges (i.e., describing the location of the concentration arrow) which we have said we do not want to get into. With that said, however, I think the suggested alternatives shed some light on how describing the read out range directly is not directly in synch with the visual representations which could cause some confusion.
I'll change the label to meeting, so we can discuss.
@twant, I unassigned you because it is not clear to me the examples in the design doc are clean enough yet for you to implement.
Ignoring any new alternative suggestions that I marked in red and put in sub-bullets, the phrasing should all be correct now. That said, I would like @Matthew-phet to go over the set of examples for Drink Mix and the set for Potassium Permanganate once again before implementation.
@twant, @Matthew-phet and I will discuss the changes before yours and @Matthew-phet 's meeting on Tuesday :-)
@twant, @Matthew-phet, @emily-phet and I discussed changes to the Beaker's dynamic description. There are 4 examples for Drink Mix and 4 examples for Potassium Permanganate, and each example is shown in both states (Values not checked and Values checked).
The Drink Mix examples are available in the main part of the PDOM, under the H3: Beaker heading, here BEAKER’S DYNAMIC STATE DESCRIPTION.
More examples are down under Dynamic States for the Beaker (new examples)
Please note that there have been changes to most of the descriptive scales (Solute Amount, Solution Volume, Concentration Level), so some values are highlighted in yellow as I was guessing as what they might be once the new scales are implemented in accordance with the model.
The new scales have been verified by @Matthew-phet are now in Tables in the Dynamic State Descriptions section under Dynamic Parameters & Ranges heading.
Please let us know if anything is unclear, and thanks for all your hard work.
@twant, and if you have not discussed all this with @Matthew-phet, it might be best to do that first ;-)
@twant, @Matthew-phet mentioned you would like a new issue for this issue, so I am assigning back to myself to split the issue up into smaller issues.
I'll make a issues for the new scales, and a separate issue for the changes to the beaker's description if that's needed.
This issue will be handled in in #121 , and #115, #116, #117. So closing.
Here are all the new changes and ill put the old one at the bottom
New Changes Example when qualitative and saturated, values unchecked Beaker is {{nearly full of}} a {{potassium permanganate}} solution. The solution is:
Example when qualitative and NOT saturated, values unchecked Beaker is {{nearly full of}} a {{potassium permanganate}} solution. The solution is:
Example when quantitative and saturated, values checked Beaker has 0.200 liters of a {{potassium permanganate}} solution. The solution is:
Example when quantitative and NOT saturated, values checked Beaker has 0.882 liters of a {{potassium permanganate}} solution. The solution is:
When solution is pure water, values checked Beaker has 0.882 liters of water. The solution is:
When solution is pure water, values unchecked
Solute colors
Old beaker description Case 1: Solution Concentration of drink mix Is not concentrated. Concentration readout range is 0.00 to 5.95 Molar. Drink mix contains mainly citric acid, which has a chemical formula of C6H8O7
Solution concentration of {{soluteProperty}} is {{concentrationProperty}}. Concentration readout range is {{0.00}} to {{5.0}} molar. The chemical formula for {{soluteProperty}} is {{chemicalFormulaPattern}}.
Case 2: when solute is zero Beaker {{volumeProperty}} of water, containing no solute.
Values Checked Case 1: Solution Concentration of drink mix Is not concentrated. Concentration readout range is 0.00 to 5.95 Molar. Drink mix contains mainly citric acid, which has a chemical formula of C6H8O7.
Solution concentration of {{soluteProperty}} is {{concentrationProperty}}. Concentration readout range is {{0.00}} to {{5.0}} molar. The chemical formula for {{soluteProperty}} is {{chemicalFormulaPattern}}.
Case 2: when solute is zero Beaker {{volumeProperty}} of water, containing no solute.
Values Checked Case 1: Solution Concentration of Drink mix Is 1.000 Molar. Concentration readout range is 0.00 to 5.95 Molar. Drink mix contains mainly citric acid, which has a chemical formula of C6H8O7
Solution concentration of {{soluteProperty}} is {{concentrationProperty}} molar. Concentration readout range is {{0.00}} to {{5.0}} molar. The chemical formula for {{soluteProperty}} is {{chemicalFormulaPattern}}.
Case 2: no solute (new special case) Beaker {{has volumeProperty}} liters of water, containing no solute.