phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

New description scale for Solute Amount #116

Closed terracoda closed 5 years ago

terracoda commented 5 years ago

@twant, related to #115, there are changes to Solute Amount, too. @Matthew-phet, please assign to @twant.

Here are the changes to Solution Volume. "zero" was changed to "no".

Description Range for moles
{{max amount of}} 1.000 moles
{{a lot of}} 0.850 to 0.950 moles
{{a bunch of}} 0.650 to 0.800 moles
{{some}} 0.450 to 0.600 moles
{{a low amount of}} 0.200 to 0.400 moles
{{a little}} 0.001 to 0.150 moles
{{no}} 0.000 moles
Matthew-Moore240 commented 5 years ago

looks good to me! assigning to @twant

terracoda commented 5 years ago

@twant, I think these are clear just assigning back to you and removing meeting label.

terracoda commented 5 years ago

Actually, sorry, I pointed out to @Matthew-phet in our meeting today that the current implementation doesn't result in a nice balanced keyboard experience (the number of steps for each range vary a lot).

@Matthew-phet, can you update this issue with the steps we discussed and re-assign to @twant.

terracoda commented 5 years ago

See section section 2. Key presses for sliders not balanced across ranges in the Agenda doc for the details.

terracoda commented 5 years ago

And apologies my original suggested ranges were not very balanced.

terracoda commented 5 years ago

Key presses are being handled in #128 I added details to the issue that @Matthew-phet opened.

terracoda commented 5 years ago

@twant, can you add labels "status: ready-to-review" when you have all the scales implemented?

terracoda commented 5 years ago

In https://github.com/phetsims/molarity/issues/121, I noticed extra "of", and just removed it https://github.com/phetsims/molarity/commit/c4843307401f31cecb7d443026096edc5581f3c2

Apologies, I forgot to make a commit comment!

terracoda commented 5 years ago

@twant, the Solute description scale, ranges, and key presses seem good to me. As notes in #117, there are issues with the concentrations levels.

Closing this issue.