Closed terracoda closed 5 years ago
looks good to me! assigning to @twant
@twant, I think these are clear just assigning back to you and removing meeting label.
Actually, sorry, I pointed out to @Matthew-phet in our meeting today that the current implementation doesn't result in a nice balanced keyboard experience (the number of steps for each range vary a lot).
@Matthew-phet, can you update this issue with the steps we discussed and re-assign to @twant.
See section section 2. Key presses for sliders not balanced across ranges in the Agenda doc for the details.
And apologies my original suggested ranges were not very balanced.
Key presses are being handled in #128 I added details to the issue that @Matthew-phet opened.
@twant, can you add labels "status: ready-to-review" when you have all the scales implemented?
In https://github.com/phetsims/molarity/issues/121, I noticed extra "of", and just removed it https://github.com/phetsims/molarity/commit/c4843307401f31cecb7d443026096edc5581f3c2
Apologies, I forgot to make a commit comment!
@twant, the Solute description scale, ranges, and key presses seem good to me. As notes in #117, there are issues with the concentrations levels.
Closing this issue.
@twant, related to #115, there are changes to Solute Amount, too. @Matthew-phet, please assign to @twant.
Here are the changes to Solution Volume. "zero" was changed to "no".