search

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

Aria-valuetext for sliders do not update when Solution Values checkbox is checked/unchecked #132

Closed Matthew-Moore240 closed 5 years ago

Matthew-Moore240 commented 5 years ago

Aria value text for sliders do not update immediately when checked box is checked/unchecked, the sliders have to be refocused on for them to update, which leads to a weird mismatch of qualitative and quantitative aria value text. image

terracoda commented 5 years ago

@Matthew-phet, thanks for posting. I'll add another screen shot that includes the visuals:

Screen Shot 2019-07-23 at 5 56 31 PM
terracoda commented 5 years ago

@zepumph, did you do anything useful in GFLB that would be relevant to this issue? I know you linked the two move-sphere sliders, but I'm not sure that would generalizable to this case?

zepumph commented 5 years ago

@twant I believe this is the issue we discussed this afternoon. In general I think that https://github.com/phetsims/molarity/commit/b0c89d2d8a6a979c959ebae855e94ff176067299 is a hack, and should not be implemented. Ideally AccessibleValueHandler should be the only thing directly setting aria-valuetext. The main reason for that is that I would hate for overwrite conditions or convoluted Property dependency order to produce weird logic as it came to the order in which aria-valuetext is set. If you can't see an element of AccessibleValueHandler that reaches your needs, then let me know and we can discuss!

twant commented 5 years ago

Thanks for working through this with me, @zepumph! Assigning back over to you for review, @Matthew-phet and @terracoda!

terracoda commented 5 years ago

Awesome work @twant and @zepumph. Looks good on my end. Closing.