search

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

Sim doesn't load on IE #153

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/436. Not in published version. The sim does not load past a small fraction of the loading bar in IE. This console error appears: error

twant commented 5 years ago

Tried replacing .includes with .indexOf to see if this fixes the IE issues. Will create a new dev version and test on IE soon!

twant commented 5 years ago

Okay, I just tested a new dev version on IE and it loads with that change made. @KatieWoe this is my first time going through QA processes, so I'm not quite sure how to proceed -- apologies! Would you like me to assign these back over to you as they are resolved, or create a new dev test issue once all of the issues are resolved?

The dev version with this fix is 1.5.24

KatieWoe commented 5 years ago

Generally for dev tests we check them as they are fixed on master, and for rc tests they are put in the "issues to check" section of the next rc test and we test them then.

KatieWoe commented 5 years ago

However, getting master to open in IE can be a bit of a pain, so a separate dev version could be useful in this case. It would be up to your discretion and what kind of testing would be more useful for you.

twant commented 5 years ago

@KatieWoe thanks for the advice! At this point, it would be really helpful if you're able to test the most recent dev version (1.5.0-dev.24) to verify that this issue is fixed. I tested in a virtual machine, but I don't have IE installed on my machine and I want to be sure it's fixed. Thanks for your help with this!

KatieWoe commented 5 years ago

Checked the mentioned dev version on Win 10 IE and it seemed to open just fine.

twant commented 5 years ago

Thanks, @KatieWoe! Closing this issue.