search

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

Cobalt (II) chloride: Incorrect response at "max concentration" #167

Closed terracoda closed 5 years ago

terracoda commented 5 years ago

@twant, I just happen to notice this incorrect response for Cobalt (II) chloride. This issue should have been fixed in #154. Is it clear to you why the correct alert is not coming through here?

When leaving the saturated zone for Cobalt (II) chloride, I got:

I think the correct response should be:

Here's an example from Gold (III) chloride. Screen Shot 2019-11-22 at 3 43 19 PM

terracoda commented 5 years ago

I was able to repeat the issue with Solution Volume, too. I didn't find this on a quick check on all the other solutes. It might just be an issue for this one. Screen Shot 2019-11-22 at 4 34 41 PM

twant commented 5 years ago

@terracoda thanks for catching this! Can you send along the numerical values at which this is happening? I can't seem to replicate, but would love to get to the bottom of this!

twant commented 5 years ago

And is this from master, or from a dev version?

terracoda commented 5 years ago

It should be master than I checked, but I will check again, and grab values for you, too.

terracoda commented 5 years ago

@twant, I can't reproduce it either. Maybe I hadn't properly emptied my caches! Cobalt (II) chloride all looks good! Solution Values not checked Screen Shot 2019-11-23 at 12 53 04 PM Screen Shot 2019-11-23 at 1 02 54 PM

Solution Values checked Screen Shot 2019-11-23 at 12 53 04 PM Screen Shot 2019-11-23 at 1 03 22 PM

terracoda commented 5 years ago

Closing! Thanks for taking a second look @twant. I think it's all good! I'll be more careful about emptying my caches next time.

This sim is ready for QA in my opinion.

terracoda commented 5 years ago

Or whatever the next steps are :-) Awesome work!