search

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

MolarityBeakerDescriptionNode can be the description list #170

Closed zepumph closed 5 years ago

zepumph commented 5 years ago

I noticed that is just a container Node, but the MolarityBeakerDescriptionNode itself doesn't have any PDOM content. Perhaps try getting rid of beakerDescriptionList in exchange for calls to this instead.

twant commented 5 years ago

Thanks for these suggestions! I just implemented and pushed these changes for this issue, along with #168 and #169. Do you want to review to confirm that these are changed as you'd imagined @zepumph?

zepumph commented 5 years ago

I moved the tagName to the options, since that is most idiomatic to phet code and it wasn't totally obvious that that was a setter for the supertype when lumped in with the local storage of passed in parameters.

zepumph commented 5 years ago

Your changes look good. Closing