solute amount aria values text depends on current solute

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/molarity

GNU General Public License v3.0

2 stars 6 forks source link

solute amount aria values text depends on current solute #187

Closed zepumph closed 4 years ago

zepumph commented 4 years ago

Discovered while working on https://github.com/phetsims/molarity/issues/165#issuecomment-563452630.

Here is a screenshot demonstrating it. I just loaded the sim and then changed the solute once:

We can pass a11yDependencies into the sliderOptions to remedy this

zepumph commented 4 years ago

Please review @twant, close if all is well.

zepumph commented 4 years ago

@twant and I found a bug here, we want to support client dependencies without blowing away the default in VerticalSlider. @twant still assigned for a spot check.

twant commented 4 years ago

Looks good! Closing. Thanks @zepumph