search

phetsims / molarity

"Molarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molarity
GNU General Public License v3.0
2 stars 6 forks source link

Convert memeber vars to private vars when applicable #197

Closed zepumph closed 4 years ago

zepumph commented 4 years ago

I'm looking through describers and seeing a fair number of variables that are only needed in the constructor, but are still stored on this. For example currentRegion used in a few describers. Can we make those let vars instead?

twant commented 4 years ago

updated! @jessegreenberg would you mind reviewing and closing when you have a minute?

twant commented 4 years ago

@jessegreenberg and I looked over this today & closed