Closed zepumph closed 4 years ago
@terracoda, @jessegreenberg and I went ahead and created the RC, but would still love your eyes on it (I didn't see anything out of place, but wanted to make sure you didn't see anything amiss!). The link is: https://phet-dev.colorado.edu/html/molarity/1.5.0-rc.1/phet/molarity_a11y_view.html. Thanks!
Tagging RC issue for this sim https://github.com/phetsims/QA/issues/464, too.
@twant, @jessegreenberg, @Matthew-phet, I just had a careful listen to Molarity on master and on the 1.5.0-rc link 1.5.0-rc link
I think things are sounding fantastic. I didn't use the A11y View much. I was focusing on the actual responses.
I found one issue - one edge case which may have not have been documented in the design doc, even (sorry). The case is when the user uses home and end keys on the Solute Amount slider and jumps to zero solute from a state where the solution was previously saturated. The solution is described "lighter" which is kind of true, but it might be more appropriate to say it is clear and that it is water.
The responses in question - when jumping from a saturated solution directly to pure water:
For comparison the response - when jumping from a concentrated solution - NOT yet saturated - to water:**
Possible Solutions: Option 1: - Combine "No longer saturated." with our current pure-water phrase to explicitly make it clear that the solution is both no longer saturated and now pure water.
OR
Option 2: Use our pure-water phrase and assume learners will know/deduce this state is no longer saturated.
@Matthew-phet, I need your thoughts here. @Matthew-phet, please comment in #199, and not here.
Thanks @terracoda, moving comments to a new issue to track outside of this one: https://github.com/phetsims/molarity/issues/199
Thanks @jessegreenberg for making a new issue, and I checked the review item in https://github.com/phetsims/molarity/issues/198#issue-537840314. I've done my review.
There is already an issue open for the last remaining checkbox, and an RC version has been created. I'm going to close this.
I think we are close to an RC, but seeing as this is my last day for vacation, I think we should likely make a central issue for all to see the current progress in the repo.
Still to do: