Closed pixelzoom closed 1 year ago
This is ready for PhET-iO design review by @arouinfar.
Following the same conventions used in Geometric Optics (see https://github.com/phetsims/geometric-optics/issues/440#issuecomment-1226228772) here's a summary of the changes:
Properties related to Options were formerly under moleculePolarity.global.model
. They are now under moleculePolarity.global.model.preferences
.
moleculePolarity.general.view.navigationBar.phetButton.phetMenu.optionsMenuItem
no longer exists, because there is no Options menu item in the PhET menu.
moleculePolarity.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule
no longer exists, because there is no Options dialog. Controls that appeared in the Options dialog were moved to the General tab of the Preferences dialog.
Controls that were added to the General tab of the Preferences dialog now appear under moleculePolarity.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.archetype.preferencesPanels.generalPreferencesPanel.simPreferences
. The simPreferences
naming convention was chosen in https://github.com/phetsims/joist/issues/837#issuecomment-1224743329. Feel free to recommend a different convention, since that's what this review is about.
Reviewed with @matthew-blackman and everything looks good @pixelzoom. Closing.
Related to https://github.com/phetsims/joist/issues/837 ...
Some of this has already been handled by @zepumph in https://github.com/phetsims/joist/issues/837.