search

phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Add support for dynamic locale #140

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

... similar to what was done in https://github.com/phetsims/natural-selection/issues/319.

pixelzoom commented 2 years ago

This sim is next on the priority list, so labeling as high.

pixelzoom commented 2 years ago

I published 1.3.0-dev.1 for brands=phet,phet-io as a baseline before starting this work.

pixelzoom commented 2 years ago

Good progress on this today. Remaining work is indicated by TODO comments in the code.

pixelzoom commented 2 years ago

@arouinfar this is ready for review. Unlike Natural Selection and Geometric, I did not instrument additional Text/RichText nodes, and all translated StringProperties are therefore not discoverable by inspecting Text/RichText elements in Studio. If you want additional Text/RichText instrumented, please identify them.

pixelzoom commented 2 years ago

Oops, I still have some layout work to do here. Assigning back to me.

pixelzoom commented 2 years ago

OK, ready for review.

arouinfar commented 2 years ago

@pixelzoom I reviewed the tree in master, and things are looking good. I see linked properties back to StringProperties where I would expect, and the dynamic layout seems good.

The only odd case I found was the screen icons. The atom name can spill outside of the bounds in the iconic version, but that doesn't happen to the atoms in the play area.

image
pixelzoom commented 2 years ago

Fixed, back to @arouinfar to verify. Feel free to close if it looks OK.

arouinfar commented 2 years ago

Thanks @pixelzoom, looks good!

image
pixelzoom commented 1 year ago

Commits above were incorrectly tagged for this issue, and should have been tagged for https://github.com/phetsims/molecule-polarity/issues/141.