Closed arouinfar closed 1 year ago
... This looks weird, and we should likely set
slider.visibleProperty
tophetioFeatured: false
and update the example in #149.
I could also address this by setting phetioVisiblePropertyInstrumented: false
for the slider, so it can't be hidden. But it's more work to override the default. And so what if someone does this -- there are lots of things that you can do with PhET-iO that you shouldn't. So my recommendation is to leave the implementation as-is, set phetioFeatured: false
if you'd like, and definitely choose a different example for examples.md.
I reviewed the tree, and the only issue I found with the overrides was slider.visibleProperty
.
So my recommendation is to leave the implementation as-is, set phetioFeatured: false if you'd like, and definitely choose a different example for examples.md.
Agreed. I've updated the overrides, but since I can't regenerate the API files, I'm not going to commit it. I'll take care of the examples in #149
@pixelzoom can you please take care of the commit?
In the above commits, overrides.js was updated and the API file re-generated. Back to @arouinfar for review, close if it looks OK.
Thanks @pixelzoom! Looks good in master, closing.
Related to #142
There have been many common code changes since 1.2, so it would be good to review the
phetioFeatured
overrides for the upcoming release.One thing that seems odd is that examples.md includes an example that hides the Electronegativity slider, but that leaves behind an empty panel. This looks weird, and we should likely set
slider.visibleProperty
tophetioFeatured: false
and update the example in #149.