Migrate overrides.js into code

pixelzoom commented 1 year ago

Prior to the 1.3 release https://github.com/phetsims/molecule-polarity/issues/137, migrate overrides.js into code.

pixelzoom commented 1 year ago

I'm down to this in overrides.js:

   "moleculePolarity.threeAtomsScreen.view.electronegativityPanels.atomAElectronegativityPanel.visibleProperty": {
      "phetioFeatured": true
    },
    "moleculePolarity.threeAtomsScreen.view.electronegativityPanels.atomBElectronegativityPanel.visibleProperty": {
      "phetioFeatured": true
    },
    "moleculePolarity.threeAtomsScreen.view.electronegativityPanels.atomCElectronegativityPanel.visibleProperty": {
      "phetioFeatured": true
    },
    "moleculePolarity.twoAtomsScreen.view.electronegativityPanels.atomAElectronegativityPanel.visibleProperty": {
      "phetioFeatured": true
    }

Missing is moleculePolarity.twoAtomsScreen.view.electronegativityPanels.atomBElectronegativityPanel.visibleProperty, the electronegativity panel for atom “B” in the “Two Atoms” screen. @arouinfar confirmed that omission is an error. That makes it easier to migrate phetioFeatured into ElectronegativityPanel, but will require an API change. Coming up...

pixelzoom commented 1 year ago

Migration is completed. There was 1 API change, due to the 1 bug noted in https://github.com/phetsims/molecule-polarity/issues/154#issuecomment-1536717810.

Compared to https://github.com/phetsims/geometric-optics/issues/459, this went quickly, ~1 hour.

Closing.

phetsims / molecule-polarity

Migrate overrides.js into code #154