phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

"Bond Character Panel" title is not centered in locales other an English #155

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.4

Browser Safari 16.4

Problem description For https://github.com/phetsims/qa/issues/952 the title of the bondCharacterPanel doesn't stay centered in locales other than English (ex. German). This is easily seen with ?stringTest=dynamic.

Steps to reproduce

  1. Add ?stringTest=dynamic to end of url
  2. On the Two Atoms screen, check the Bond Character checkbox
  3. Press the down arrow to cycle through different words.

Visuals

Screenshot 2023-06-05 at 4 35 53 PM

Deutsch:

Screenshot 2023-06-05 at 4 32 23 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: antidisestablishmentarianism URL: https://phet-dev.colorado.edu/html/molecule-polarity/1.3.0-dev.3/phet/molecule-polarity_all_phet.html?stringTest=dynamic Version: 1.3.0-dev.3 2023-06-05 15:13:48 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Safari/605.1.15 Language: en-US Window: 1357x706 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
pixelzoom commented 1 year ago

There's a problem with the rightmost ("more ionic") label too. It does not stay right justified. See screenshots above.

Nancy-Salpepi commented 1 year ago

Ah you beat me to it! I was just coming back to add that!

pixelzoom commented 1 year ago

Fixed in the above commit. Tested with ?stringTest=dynamic, screenshots below. Note that vertically centering the labels in the whitespace is not a goal.

@Nancy-Salpepi please verify in master, close if OK.

screenshot_2571 screenshot_2572
Nancy-Salpepi commented 1 year ago

Fixed in master. Closing.