phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Alignment icons for dipole checkboxes #159

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

In https://github.com/phetsims/qa/issues/952, @Nancy-Salpepi reported:

@pixelzoom this is minor, but I noticed that the dipole symbols in the View panel on the Three Atoms screen aren't aligned in English or in any locale. This is different from what I just saw when testing Geometric Optics where the symbols have right alignment. Didn't know if you wanted to keep as is or make the change.

Screenshot 2023-06-09 at 12 07 22 PM
pixelzoom commented 1 year ago

@Nancy-Salpepi thanks for reporting. But closing as "won't fix".

Slack#DM with @arouinfar:

@pixelzoom said: My recommendation is to do nothing, because: (1) Nothing has changed, the alignment has always been like this. (2) Horizontally aligning all of the icons in a control panel is not (afaik) a general requirement or PhET UI-design pattern. And I’m not a fan of doing it everywhere — depending on the translated strings, the icons can become very spatially separated from their labels. Yes, it works on phones, but that’s because of the form-factor of phones, not because it’s a generally good layout pattern. Do you agree?

@arouinfar said: Agreed!

pixelzoom commented 1 year ago

Btw... These icons did end up getting aligned as the result of some layout changes to panels. Since that's now the default behavior for scenery layout, I didn't see the point in doing work to unalign the icons.

screenshot_2640