phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Title of Bond Dipole Checkbox only changes on one screen during Migration #165

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.4

Browser Safari 16.5

Problem description For https://github.com/phetsims/qa/issues/956, in the Migration Wrapper: If I change the title of the bondDipoleCheckbox on the Two Atoms Screen in version 1.2, it doesn't change the title on the Three Atoms Screen in 1.3. However, if I change the titles of partialChargesCheckbox and eFieldControl on the Two Atoms Screen--those changes are present on both screens after the migration.

Steps to reproduce

  1. In the Migration Wrapper on the Two Atoms Screen, change viewControls.bondDipoleCheckbox.labelNode.labelText.textProperty
  2. Press Migrate Now

Visuals Version 1.2:

Screenshot 2023-06-21 at 10 04 58 PM

Version 1.3:

Screenshot 2023-06-21 at 10 05 43 PM Screenshot 2023-06-21 at 10 07 05 PM
pixelzoom commented 1 year ago

The labels are in fact different on the 2 screens. On the Two Atoms screen, it's "Bond Dipole" (singular), while the Three Atoms screen is "Bond Dipoles" (plural). Does that explain what you're seeing @Nancy-Salpepi?

Nancy-Salpepi commented 1 year ago

ah ok. Thanks.