search

phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Convert Properties that are booleans to BooleanProperties? #63

Closed zepumph closed 7 years ago

zepumph commented 7 years ago

from code review #30 I'm sure I see the added value of this, but maybe you do. I know it helps when it comes to PhET-iO instrumentation, but only a bit, and that is far down the road. Your call.

pixelzoom commented 7 years ago

FYI... When this sim was written (2014) there was no BooleanProperty, or any other type-specific Properties.

pixelzoom commented 7 years ago

Done, @zepumph please review.

BooleanProperty is used for all of the check boxes, and the E-field on/off switch.

zepumph commented 7 years ago

FYI... When this sim was written (2014) there was no BooleanProperty, or any other type-specific Properties.

Ahhh makes sense, thanks for informing. All looks good here. Closing

zepumph commented 7 years ago

BooleanProperty is used for all of the check boxes, and the E-field on/off switch.

Is this directed at me as a "when you are developing this is what phet does" or more of a "this is how it is implemented in this sim for the world to know"?

pixelzoom commented 7 years ago

Just an FYI about where the BooleanProperties are used, in case you wanted to check to see if I missed any.