Closed pixelzoom closed 3 years ago
I moved a couple of change requests to #91, because they are going to require significant effort.
@arouinfar The requests in the list above are done, and ready for review in master.
@arouinfar pointed out that I used 'RGB' instead of 'RWB' for one of the ?surfaceColor
values. Fixed in the above commit.
@pixelzoom everything is looking good in master. I'll leave this issue open and self-assigned since we still need to review the Three Atoms screen in detail.
@arouinfar since these change requests were for the "Two Atoms" screen, I've retitled this issue to "PhET-iO change requests (Two Atoms screen)", and I'm going to close this issue.
Related to #85... Change requests for PhET-iO instrumentation:
Uninstrument these elements:
platesNode
partialCharge*Node
bondDipole*Node
molecularDipoleNode
arrow*Node
, the individual hint arrowselectrostaticPotentialColorKey
electronDensityColorKey
Add these query parameters:
dipoleDirection
, values 'positiveToNegative' and 'negativeToPositive', add to spreadsheetsurfaceColor
, values 'RWB' and 'ROYGB', add to spreadsheetStudio tree structure:
view.colorKeysNode.visibleProperty
electronegativityPanels
, all panels underelectronegativityPanels
moleculeNode.dragListeners
moleculeNode.hintArrowsNode
eFieldEnabledProperty
up into model.Documentation (
phetioDocumentation
):angleProperty
: indicate which direction is positivepositionProperty
: relative to the view coordinate frame, (0,0) at upper-left of layoutBounds, +x right, +y down.partialChargeProperty
: "qualitative scalar representation of partial charge, computed as the electronegativity difference"bond.dipoleProperty
: "qualitative vector representation of dipole, based on the electronegativity difference"molecule.dipoleProperty
: 'the molecular dipole, vector sum of the bond dipoles'surfaceColorProperty
: indicate that it applies to the Real Molecules screen