phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

PhET-iO change requests (Two Atoms screen) #89

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Related to #85... Change requests for PhET-iO instrumentation:

Uninstrument these elements:

Add these query parameters:

Studio tree structure:

Documentation (phetioDocumentation):

pixelzoom commented 3 years ago

I moved a couple of change requests to #91, because they are going to require significant effort.

@arouinfar The requests in the list above are done, and ready for review in master.

pixelzoom commented 3 years ago

@arouinfar pointed out that I used 'RGB' instead of 'RWB' for one of the ?surfaceColor values. Fixed in the above commit.

arouinfar commented 3 years ago

@pixelzoom everything is looking good in master. I'll leave this issue open and self-assigned since we still need to review the Three Atoms screen in detail.

pixelzoom commented 3 years ago

@arouinfar since these change requests were for the "Two Atoms" screen, I've retitled this issue to "PhET-iO change requests (Two Atoms screen)", and I'm going to close this issue.

85 (Add basic PhET-iO instrumentation) is still open, assigned to you and @kathy-phet, and that's the appropriate place to continue your review of the "Three Atoms" screen . If you have change requests for that screen, create another issue like this one. Thanks!