phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Molecules can change other molecule's orientation #157

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/280 and https://github.com/phetsims/QA/issues/279 Found on the real molecules screen when using the dropdown box to select different molecules. When you move a molecule by clicking on it and dragging it, then switch to a different molecule, that molecule is unaffected and returning to the original resets it to its default position. If you click in another area of the screen and drag it still moves the molecule. However, this changes the orientation of the other molecules as well. Returning to the original shows that the molecule now has a new default position it will return to. This occurs in the published version and is very minor. From @jonathanolson on slack:

I don't have a problem with a functional change that either makes them independent, or resets the transformation for each real molecule.

arouinfar commented 5 years ago

Nice catch @KatieWoe. This is definitely a bit strange.

Steps to reproduce:

  1. On startup, change water's orientation by clicking on the molecule itself.
  2. Switch to a different molecule.
  3. Switch back to water. The orientation has reverted to the startup orientation:

water

  1. Change water's orientation by clicking an empty part of the play area and dragging it.
  2. Switch to another molecule. Its orientation now matches water.
  3. Switch back to water. Its orientation remains as you left it in step (4).

water2

Steps 1-3 don't seem so odd to me, but steps 4-6 are super weird. Not only have I changed water's orientation -- I've changed everything's orientation and have essentially overwritten the startup orientation.

@jonathanolson I think it would make the most sense to follow the behavior in steps 1-3, regardless of whether the molecule or empty play area was clicked and dragged.

jonathanolson commented 5 years ago

Implemented and patching in the release branches. @KatieWoe can you verify master?

KatieWoe commented 5 years ago

Looks good on master

KatieWoe commented 5 years ago

Seems fixed in rc.2