phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Rotation of outer lone pairs #158

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/279. Very minor. Appears in published version When switching between the real and model versions of a molecule any outer lone pairs may rotate. This seems to occur when switching from model to real. To Reproduce:

  1. Go to the real molecule screen
  2. Go to options and activate the outer lone pairs
  3. Go to CO2 (others will sometimes work, this seems most consistent)
  4. Switch between the real and model radio buttons. Observe behavior

twisting

arouinfar commented 5 years ago

Nice observation @KatieWoe. This definitely looks a bit strange to me, but I think the rotation is occurring because the relative angle of the lone pairs is different.

Here's an alternative view of Model. I'm not sure why the angle between the external lone pairs is a bit variable.

@jonathanolson do you know what's going on here?

jonathanolson commented 5 years ago

I don't recall the exact reason, but I believe it was known and was too minor to handle before.

I think it's due to how the real molecule data is initialized.

arouinfar commented 5 years ago

Thanks @jonathanolson. I would agree it's still pretty minor, so I'll close as type:wontfix.