search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Color of Br is incorrect #159

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

Discovered in #153, and should be addressed before the next release, so tagging https://github.com/phetsims/QA/issues/280 too.

According to https://github.com/phetsims/nitroglycerin/blob/master/js/Element.js, the color of bromine (Br) should be rgb(190,30,20) and boron (B) should be rgb(255,170,119).

Currently, it appears Br and B are both rgb(255,170,119).

BrF5: image

BF3: image

jonathanolson commented 5 years ago

Should be patched in master and the release branches. Can you verify?

arouinfar commented 5 years ago

@jonathanolson I pulled all, but the color of Br and B still appear to be the same in master. Not sure what's going on.

jonathanolson commented 5 years ago

I hadn't pushed somehow, sorry! Fixed, and tested on another computer to ensure. Can you verify?

arouinfar commented 5 years ago

Looks good in master @jonathanolson!

KatieWoe commented 5 years ago

This seems to be correct in rc.2