search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Molecule in screen selection and boded atoms in model screen disappears #161

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Device Dirac OS 10.11.6 and 10.12.6 (and 10.10 but this browser is not supported there) Browser Firefox Problem Description For https://github.com/phetsims/QA/issues/279 and https://github.com/phetsims/QA/issues/280 On the home screen and in the nav bar of the sim screens, the Real Molecules image is missing the ball and stick molecule, and only has the elements' letters. webgl=false seems to bring the image back. Steps to reproduce:

  1. Go to Mac OS 10.11.6 firefox
  2. Look at image for real molecules

Screenshot molecule shapes_ basics screenshot-1 1

KatieWoe commented 5 years ago

This also seems to be there in the published version.

KatieWoe commented 5 years ago

The double and triple bonded atom selections on the model screen are also invisible @jonathanolson And they all disappear in basics in projector mode and do not come back if you turn it off. In the non-basics sim the lone pair disappears in projector mode, but not the single bond.

KatieWoe commented 5 years ago

If you use showPointerAreas the boded atoms seem to be shifted out of their clickable area.

KatieWoe commented 5 years ago

I thought there may be a problem with the device, but I checked 10.11 on Magnus and it shows the problem as well.

jonathanolson commented 5 years ago

I've spent a lot of time tracking this down and looking for solutions, but I'm stuck since this looks like a browser OR three.js bug that happens when a WebGL context is reused. This means that only the 1st screen icon works, or only the 1st set of bond label icons work, since those used shared contexts. Unfortunately, just using more contexts isn't an option currently, since browsers like to "dump" older contexts when you create a bunch (so it could cause the main display's context to stop working). I'm not finding any particular workarounds yet, so given the contortions that would potentially be needed, I've reached the point where I would personally leave it as will-not-fix.

@ariel-phet thoughts?

jonathanolson commented 5 years ago

Patched on master and RCs to downgrade Firefox OS X 10.10-10.13 to Canvas. @KatieWoe can you check the behavior on master with Dirac?

KatieWoe commented 5 years ago

Tested all browsers on 10.10, 10.11, and 10.12 on Dirac. No problems seen.

jonathanolson commented 5 years ago

Since this is worked around, marking as fixed-pending-testing.

KatieWoe commented 5 years ago

@jonathanolson this fix seems to have only been applied to Molecule Shapes Basics. It still happens on Molecule Shapes

jonathanolson commented 5 years ago

Applied to Molecule Shapes, created rc.3 at https://phet-dev.colorado.edu/html/molecule-shapes/1.2.0-rc.3/phet/molecule-shapes_en_phet.html. Should I update the RC issue or create another?

KatieWoe commented 5 years ago

Haven't gotten too far, so update the rc and leave a comment saying you did that

KatieWoe commented 5 years ago

Looks fixed in that rc.3