search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Playback wrapper lag #177

Closed phet-steele closed 2 years ago

phet-steele commented 3 years ago

I just want to note, that like with some other sims, this sim has some mildy slow performance in the playback wrapper. It's not the worst I've seen, admittedly, but I just want to make note of it. It really just looks like the playback is being played in slow motion when dragging bonds around. Note that in reality my mouse was moving much quicker than what you see below:

MS01

Seen on Win 10 Chrome. For phetsims/QA/issues/635.

liammulh commented 3 years ago

Not seeing this on macOS + Safari.

jonathanolson commented 3 years ago

@zepumph I think it was discussed that playback performance wasn't something to optimize, correct? (The approach definitely rebuilds the view)

zepumph commented 3 years ago

Yes. I have not yet recommended any time to solve this in the past, and I don't think @samreid has either. In my opinion, the playback wrapper is a tool that we use to ensure that the recording are complete. It also serves as an example of what PhET-iO can accomplish. I don't think time needs to be devoted to this issue personally.

zepumph commented 2 years ago

We won't be supporting the playback wrapper anymore, see https://github.com/phetsims/phet-io/issues/1854. Closing