PhET-iO Design Comments - Round 2

[arouinfar]

@jonathanolson @zepumph here are the remaining issues for Molecule Shapes (and Basics) that I mentioned in PhET-iO meeting. Feel free to split these off into separate issues, as necessary.

• [x] Add documentation to model.moleculeQuaternionProperty
• [ ] When selecting *Screen.model in Studio, you can see the initial value. Can we also display the current value?
• [x] Make removeButton.enabledProperty phetioReadOnly: true (should be model controlled, not user controlled)
• [x] Rename maxPairsProperty to maxConnectionsProperty and make it a public query parameter called maxConnections.
• [x] Add labelText to all checkboxes so that the client can change the strings.

EDIT: Please note that these requests all also apply to molecule-shapes-basics.

[zepumph]

@jonathanolson, please let me know if I can be of any assistance here, or if I should take over.

[jonathanolson]

Add labelText to all checkboxes so that the client can change the strings.

I didn't immediately adjust the projector-mode checkbox (as that's across other sims), should I add it to that?

[jonathanolson]

When selecting *Screen.model in Studio, you can see the initial value. Can we also display the current value?

@zepumph I'm not sure how to handle this, how do we show current state (instead of initial state) in studio?

[jonathanolson]

Besides the above comments, I've implemented the changes. @arouinfar can you verify?

[arouinfar]

Thanks @jonathanolson. Everything looks good in master in molecule-shapes and molecule-shapes-basics.

Add labelText to all checkboxes so that the client can change the strings.

I didn't immediately adjust the projector-mode checkbox (as that's across other sims), should I add it to that?

Good call! I forgot about the options menu. Thanks for adding it to the Show Outer Lone Pairs checkbox, but I think we can leave projector mode as-is.

When selecting *Screen.model in Studio, you can see the initial value. Can we also display the current value?

@zepumph I'm not sure how to handle this, how do we show current state (instead of initial state) in studio?

This was more of a question than a request. If it's not immediately obvious, we don't need to worry about it.

[arouinfar]

I want to feature labelText.textProperty in the overrides, so leaving this open and self-assigned.

[arouinfar]

I updated the description of maxConnections in the client guides and featured labelText.textProperty for checkboxes. @jonathanolson once #182 is wrapped up, we're ready to proceed to QA. Closing.

[jonathanolson]

Comment says closing, so closing this issue!