phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Bond Angles Missing #191

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 11.6

Browser safari

Problem description https://github.com/phetsims/qa/issues/715 https://github.com/phetsims/qa/issues/716

In the Model and Real Molecules Screens, the Bond Angles are not shown when the checkbox is checked.

Visuals

Screen Shot 2021-10-08 at 8 11 21 AM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Molecule Shapes‬ URL: https://phet-dev.colorado.edu/html/molecule-shapes/1.4.0-dev.1/phet/molecule-shapes_all_phet.html Version: 1.4.0-dev.1 2021-10-07 21:09:50 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1199x675 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Nancy-Salpepi commented 2 years ago

Bond Angles are also missing in PhET-iO wrappers

Nancy-Salpepi commented 2 years ago

@jonathanolson I just wanted to note that when using the query parameter webgl=false, the bond angles are present.

jonathanolson commented 2 years ago

Should be fixed in master (although there seems to be another unrelated layout issue).

@Nancy-Salpepi can you confirm?

Nancy-Salpepi commented 2 years ago

@jonathanolson this looks fixed in master for both molecule shapes and molecule shapes basics.

jonathanolson commented 2 years ago

Thanks!