search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Console errors when 'Options' is selected in PhET-iO menu #193

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 11.6

Browser safari 15

Problem description https://github.com/phetsims/qa/issues/715

In the State Wrapper, with the query parameter ?phetioDebug, console errors appear when 'options' is selected in the PhET-iO menu. Once that occurs, the downstream sim will no longer respond to any changes made in the upstream sim.

Steps to reproduce

  1. Open State wrapper and console
  2. Add ?phetioDebug to url
  3. Open the PhET-iO menu and select 'Options' --console errors will appear
  4. Exit out of menu, make changes to sim --nothing happens downstream

Visuals

Screen Shot 2021-10-09 at 9 19 06 AM
jonathanolson commented 2 years ago

Good find! I think the above commit should fix this, can you verify in master?

Nancy-Salpepi commented 2 years ago

Thanks @jonathanolson! Looks good now on Master.

jonathanolson commented 2 years ago

Thanks!