search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Mirror Wrapper not working properly #195

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 3 years ago

Test device MacBook Air (m1 chip)

Operating System 11.6

Browser safari

Problem description https://github.com/phetsims/qa/issues/715 https://github.com/phetsims/qa/issues/716

The mirror image does not always match the original sim.

Steps to reproduce

  1. Select the Model Screen
  2. Select 'Remove All'
  3. Check 'Show Bond Angles'
  4. Add a single bond and then another--they two sims will no longer match
  5. Rotate around, add more bonds--sims won't match

Visuals mirrormolecules

KatieWoe commented 3 years ago

I saw this in basics as well, and in the recording wrapper. It seems to occur when dragging the central atom as well for me.

mirroroff
jonathanolson commented 3 years ago

Fixed in the tagged issue. Can you verify?

KatieWoe commented 3 years ago

The part I saw looks ok on master. @Nancy-Salpepi I'll leave the rest of the conformation to you.

Nancy-Salpepi commented 3 years ago

My part looks good on master as well @jonathanolson

KatieWoe commented 2 years ago

This is looking ok so far in rc.1, but since mirror wrapper was replaced with Input Record and Playback it is a bit harder to tell.

KatieWoe commented 2 years ago

Looks ok in rc.1. Closing. Will reopen if something comes up.