search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Delete IE11StencilWarningNode, because IE is no longer supported. #217

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

From the CRC:

  • [ ] IE is no longer supported. With that in mind remove IE-specific workarounds

So can IE11StencilWarningNode.js be deleted, instead of spending the effort to convert to TS?

IE11StencilWarningNode.js was writting by @jonathanolson, and is used exclusively in molecule-shapes. So assigning to him.

pixelzoom commented 2 years ago

Or if you don't want to delete it, can I move it to molecule-shapes? It's used exclusively by molecule-shapes, and should not be used by other sims.

pixelzoom commented 2 years ago

I transferred this issue from scenery-phet to molecule-shapes. And I moved IE11StencilWarningNode.js to molecule-shapes, where you can delete it at your leisure.

jonathanolson commented 2 years ago

Committed above, thanks! Closing.