search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Add links to `stringProperty` to Real/Model radio buttons #226

Closed arouinfar closed 1 year ago

arouinfar commented 2 years ago

For #223

@jonathanolson can you add a link to the appropriate stringProperty to realRadioButton and modelRadioButton?

arouinfar commented 2 years ago

Tagging for https://github.com/phetsims/qa/issues/844.

zepumph commented 1 year ago

The text is actually the content node of the the radioButton, so we needed substructure and couldn't have the stringProperty as a sibling to radioButton Properties. How is this?

image

arouinfar commented 1 year ago

The text is actually the content node of the the radioButton, so we needed substructure and couldn't have the stringProperty as a sibling to radioButton Properties. How is this?

Perfect, thanks @zepumph! You read my mind -- the goal was for users to find the appropriate stringProperty while they are looking at the radio buttons in the view, and now they can.