search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Studio geometry listing may not match sim #234

Closed KatieWoe closed 2 years ago

KatieWoe commented 2 years ago

Test device Dell Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/844 and https://github.com/phetsims/qa/issues/845. When in studio, looking at a molecule's molecule or electron geometry, you may see it is diatomic, but the sim itself says linear. Should these two match?

Visuals

diatomicorlinear
arouinfar commented 2 years ago

Good catch @KatieWoe.

I've never seen "diatomic" as a molecular geometry. Diatomic molecules have a linear geometry.

@Nancy-Salpepi have you ever seen diatomic used as a classification of molecular geometry?

Nancy-Salpepi commented 2 years ago

@arouinfar I have never seen "diatomic" used as a classification. As you said, they have linear geometry.

arouinfar commented 2 years ago

Thanks @Nancy-Salpepi. Seems like we should remove "Diatomic" @jonathanolson.

jonathanolson commented 2 years ago

The sim needs to differentiate between these internally (since 3 atoms in linear is different than diatomic, it's a fundamentally different structure). Each geometry needs to have a certain number of atoms.

So that might be possible, but it would be a significant refactor internally (many hours at least). How much time would this be worth?

arouinfar commented 2 years ago

Thanks for the clarification @jonathanolson. I would be more concerned if DIATOMIC appeared instead of LINEAR on the Real Molecules Screen. Since the smallest molecule on that screen is triatomic, it doesn't. Let's close.