Closed Nancy-Salpepi closed 1 year ago
I believe fixed in master, patched up on release branches. @Nancy-Salpepi can you check master?
The size of the pointer/touch areas in the Name panel still changes with some locales (ex. Hausa, Igbo) as I add bonds/lone pairs.
Sorry, I mis-read the issue!
I believe this should be patched up a bit better in master and the branches.
@Nancy-Salpepi does this look good in master? Thoughts?
I think things are looking very nice in master!
Sounds good!
Actually @jonathanolson I am noticing that this part isn't fixed with all locales:
The resizing of the panel and its height changing should be fixed
Ex. Igbo, the size of the name panel still changes in master (I see the shift when the molecule geometry is trigonal planar). Another example is with Yoruba.
Sorry!
No need to apologize, thank you for finding this! Reproducing, working on it.
I believe this is fixed on master (and I've patched the release branches). @Nancy-Salpepi can you verify on master?
I checked several locales and the Name panel size looks like it remains fixed. However, now with some locales the pointer/touch area size changes as I add bonds and they can overlap. Some examples are with Lao and Yaruba:
In the Basics version, the pointer/touch areas can extend beyond the panel. Here is an example with Lao:
I'm on macOS 13.2.1 and I see this with safari and chrome.
Apologies about that! The touch areas for the two were reversed. Can you verify master now? Thank you!
I looked at several locales and all seems to be correct now 🙂.
Please close after verifying!
This looks good in rc.2 for this sim and basics.
Test device MacBook Air M1 chip
Operating System 13.1
Browser Chrome
Problem description For https://github.com/phetsims/qa/issues/905 and https://github.com/phetsims/qa/issues/906, the size of the pointer areas in the Name panel changes with longer text locales such as Hausa. This is seen on both screens.
Steps to reproduce
Visuals
https://user-images.githubusercontent.com/87318828/220463318-5d54a5d0-9055-41d2-af17-b358d85a6215.mp4