phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Size of pointer areas changes as bonds are added #242

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.1

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/905 and https://github.com/phetsims/qa/issues/906, the size of the pointer areas in the Name panel changes with longer text locales such as Hausa. This is seen on both screens.

Steps to reproduce

  1. Add ?showPointerAreas to url
  2. Change locale to Hausa
  3. Check both checkboxes in the Name panel
  4. Add bonds and lone pairs

Visuals

https://user-images.githubusercontent.com/87318828/220463318-5d54a5d0-9055-41d2-af17-b358d85a6215.mp4

jonathanolson commented 1 year ago

I believe fixed in master, patched up on release branches. @Nancy-Salpepi can you check master?

Nancy-Salpepi commented 1 year ago

The size of the pointer/touch areas in the Name panel still changes with some locales (ex. Hausa, Igbo) as I add bonds/lone pairs.

jonathanolson commented 1 year ago

Sorry, I mis-read the issue!

I believe this should be patched up a bit better in master and the branches.

  1. The width of the pointer areas should be fixed
  2. The resizing of the panel and its height changing should be fixed
  3. The height of the pointer areas slightly changes (due to the text being sized down). I'd prefer to leave as-is, as I don't think this is significant.

@Nancy-Salpepi does this look good in master? Thoughts?

Nancy-Salpepi commented 1 year ago

I think things are looking very nice in master!

jonathanolson commented 1 year ago

Sounds good!

Nancy-Salpepi commented 1 year ago

Actually @jonathanolson I am noticing that this part isn't fixed with all locales:

The resizing of the panel and its height changing should be fixed

Ex. Igbo, the size of the name panel still changes in master (I see the shift when the molecule geometry is trigonal planar). Another example is with Yoruba.

Sorry!

jonathanolson commented 1 year ago

No need to apologize, thank you for finding this! Reproducing, working on it.

jonathanolson commented 1 year ago

I believe this is fixed on master (and I've patched the release branches). @Nancy-Salpepi can you verify on master?

Nancy-Salpepi commented 1 year ago

I checked several locales and the Name panel size looks like it remains fixed. However, now with some locales the pointer/touch area size changes as I add bonds and they can overlap. Some examples are with Lao and Yaruba:

Screenshot 2023-02-27 at 2 12 13 PM Screenshot 2023-02-27 at 2 10 29 PM

In the Basics version, the pointer/touch areas can extend beyond the panel. Here is an example with Lao:

Screenshot 2023-02-27 at 2 18 18 PM

I'm on macOS 13.2.1 and I see this with safari and chrome.

jonathanolson commented 1 year ago

Apologies about that! The touch areas for the two were reversed. Can you verify master now? Thank you!

Nancy-Salpepi commented 1 year ago

I looked at several locales and all seems to be correct now 🙂.

jonathanolson commented 1 year ago

Please close after verifying!

Nancy-Salpepi commented 1 year ago

This looks good in rc.2 for this sim and basics.