Lone Pair panel doesn't disappear when lonePairNode.visibleProperty is false

[Nancy-Salpepi]

Test device MacBook Air M1 chip

Operating System 13.2.1

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/905, when moleculeShapes.modelScreen.view.lonePairPanel.lonePairNode.visibleProperty is set to false, the Lone Pair panel remains even though it is empty. Shouldn't it disappear like the other panels do when the visible properties for everything in them are set to false?

Visuals

[arouinfar]

Thanks for reporting this inconsistency @Nancy-Salpepi.

I don't think it's critical for panels to disappear automatically, and sometimes there are circumstances that prevent it from happening, such as https://github.com/phetsims/circuit-construction-kit-common/issues/939. Not sure if there are extenuating circumstances here, or if it was simply an oversight.

That said, moleculeShapes.modelScreen.view.lonePairPanel.lonePairNode.visibleProperty is purposely not featured and we recommend that clients hide parents rather than individual children in the PhET-iO Guide. I am fine with closing this as wont-fix.

[jonathanolson]

I believe this should be fixed in master, and patched on the release branches. @Nancy-Salpepi can you verify?

[Nancy-Salpepi]

The lone pair panel now disappears. Thanks JO 🙂.

[jonathanolson]

Please close after verifying!

[Nancy-Salpepi]

This looks good in rc.2. Closing.

[Nancy-Salpepi]

Hey sorry. I have to reopen. If I set lonePairNode.visibleProperty to false, the panel disappears. If I change locale and launch the sim, it doesn't load. Here are the errors in the console:

[jonathanolson]

I believe I've fixed this in master and the branches. Can you verify on master?

[Nancy-Salpepi]

This looks fixed in master (and I verified that it doesn't happen with other panels).

[zepumph]

Awesome. Thanks @Nancy-Salpepi for the quick turnaround.

[KatieWoe]

Looks good in rc.3