phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Autoselect is sometimes broken when you mouse over something then press ctrl/opt/alt #245

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

Related to https://github.com/phetsims/qa/issues/905 and https://github.com/phetsims/qa/issues/906.

Opening this issue to track https://github.com/phetsims/studio/issues/295.

@jonathanolson there is a MR planned to handle the above studio issue, but it may come before Molecule Shapes is published. If that happens, you'll need to cherry-pick the relevant commits into Molecule Shapes and Molecule Shapes: Basics.

FYI @samreid.

zepumph commented 1 year ago

Likely Molecule Shapes will want to cherry pick https://github.com/phetsims/studio/commit/e0ffb2cc1ba7e06abe09b4c09f557f491e26bfc7 from https://github.com/phetsims/studio/issues/295#issuecomment-1446758612.

But we will want to wait for a confirmation.

samreid commented 1 year ago

@jessegreenberg and I will be collaborating on this issue around 11am MT today

UPDATE: Oops wrong repo. @jessegreenberg and I will be meeting about https://github.com/phetsims/studio/issues/295#issuecomment-1446758612

zepumph commented 1 year ago

To commit for this issue in molecule shapes:

https://github.com/phetsims/studio/commit/e0ffb2cc1ba7e06abe09b4c09f557f491e26bfc7 https://github.com/phetsims/phet-io-sim-specific/commit/9ab265d27852b33eb278b0c33ad020414baa3406

jessegreenberg commented 1 year ago

Hello! sudio#295 also included a fix for chrome stealing focus from alt key, you may need https://github.com/phetsims/studio/commit/5d5d356c7003a7628b0a3cd6810fd4b09e68d511 (preventDefault call) and the commits leading up to it.

zepumph commented 1 year ago

Sure thing. I didn't include that because Molecule Shapes RC shas were taken from master 2/21.

jessegreenberg commented 1 year ago

Ah, excellent, thank you!

zepumph commented 1 year ago
jonathanolson commented 1 year ago

Patches applied above, waiting on testing.

jonathanolson commented 1 year ago

Please close after verifying!

Nancy-Salpepi commented 1 year ago

This looks good in rc.2 for full/basics versions. Closing.