search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

titleText.visibleProperty switches back to 'true' when locale changes #246

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.2.1

Browser Safari and Chrome

Problem description For https://github.com/phetsims/qa/issues/906 and https://github.com/phetsims/qa/issues/905, for any panel on either screen, if I change the titleText.visibleProperty to false and then switch locales, the titles appear again. Also seen in the launched sim.

Steps to reproduce Ex:

  1. On the Real Molecules Screen, set moleculeShapes.realMoleculesScreen.view.optionsPanel.titleText.visibleProperty to false.
  2. Change to any locale --the titles appear
  3. Change back to English --the titles are present.

Visuals

https://user-images.githubusercontent.com/87318828/221282148-3838df9c-eb8e-4758-9a00-056263c9e3c7.mp4

jonathanolson commented 1 year ago

I believe I've fixed this up in master (there was some undesirable behavior and code in general). @Nancy-Salpepi can you verify?

jonathanolson commented 1 year ago

(this is also applied to the release branches)

Nancy-Salpepi commented 1 year ago

This is fixed in master.

jonathanolson commented 1 year ago

Please close after verifying!

Nancy-Salpepi commented 1 year ago

This looks good in rc.2 for MS and MS:Basics. Closing.