search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

"Real Molecules" screen icon image missing or partially missing #247

Closed stemilymill closed 1 year ago

stemilymill commented 1 year ago

For https://github.com/phetsims/qa/issues/905 and https://github.com/phetsims/qa/issues/906

similarities to https://github.com/phetsims/molecule-shapes/issues/161

Seen on Lenovo 100e Chromebook gen 2 with ChromeOS Version 110.0.5481.181 (Official Build) (32-bit). I first saw it on 110.0.5481.112 and then updated.

@Nancy-Salpepi does not see this on her chromebook.

I saw this in a private window but cleared my cache just in case that was the issue and there was no change.

The icon for Real Molecules is incomplete on Molecule Shapes and Molecule Shapes: Basics, and I do also see it in published. For Basics, the model is completely missing, and in Molecule Shapes, the sticks are visible and sometimes fragments of the spheres.

molecule shapes 1 6 0-rc 1 phetio standalone homescreen icon

molecule shapes basics 1 6 0-rc 1

In the Model screen, the images in the Bonding and Lone Pair panels are sometimes incomplete.

molecule shapes 1 6 0-rc 1 images

An example of alerts in console

Screenshot 2023-02-27 3 07 49 PM

jonathanolson commented 1 year ago

@kathy-phet @arouinfar I don't believe there's much I can try here except for upgrading three.js. This looks like it could be a three.js issue (most likely?), a hardware/support issue, or both.

If I do upgrade, we would lose the ability to render in canvas (currently for this sim, we have the fallback if someone doesn't have GPU support). However we'd be able to use more common code for 3d handling.

Thoughts?

kathy-phet commented 1 year ago

@jonathanolson - What is the lift to upgrade three.js? I feel like I recall you considering that previously, but that its a large amount of work.

@arouinfar - Have we received any reports from teachers on this?

@stemilymill - Was the sim usable in general? e.g. did you see rendering issues on the actual manipulatable molecule?

arouinfar commented 1 year ago

@arouinfar - Have we received any reports from teachers on this?

No, not that I recall @kathy-phet. I also looked through the repo and didn't see any reports received by phethelp.

jonathanolson commented 1 year ago

What is the lift to upgrade three.js? I feel like I recall you considering that previously, but that its a large amount of work.

Fairly uncertain. I don't remember it being too significant, but I know for sure it messes with the Canvas output. Probably at least hours?

stemilymill commented 1 year ago

@kathy-phet the sim was definitely usable and I didn't notice any rendering issues with the actual molecule

Nancy-Salpepi commented 1 year ago

The Lenovo I have is an older model than @stemilymill's and I am not seeing this issue. I have a Lenovo 100e Chromebook with ChromeOS 110.0.5481.181.

arouinfar commented 1 year ago

Thanks @Nancy-Salpepi @stemilymill. Sounds like this is very device specific and doesn't impact usability of the sim itself. Emily mentions that it occurs in published, but there haven't been any reports into phethelp about this issue, which leads me to believe it is uncommon. Given @jonathanolson's assessment, I think we can leave this as-is, but I'll let @kathy-phet make the final call.

kathy-phet commented 1 year ago

Let's close as "will not fix". If we get further reports that make us believe its common, we can re-open. So I'll close it.