search

phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Please make phetioReadOnly: false for showLonePairsCheckbox.enabledProperty #248

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

For https://github.com/phetsims/qa/issues/905

Please change showLonePairsCheckbox.enabledProperty so that it is phetioReadOnly: false

Discussed this with @arouinfar on slack. From Amy: I think I asked for it to be read-only because it was automatically disabled on startup. That’s no longer relevant. Good catch! Since the sim no longer automatically disables the checkbox, the enabledProperty doesn’t need to be read-only anymore. Can you open an issue to make it phetioReadOnly: false?

jonathanolson commented 1 year ago

Patched up. @Nancy-Salpepi can you verify on master?

Nancy-Salpepi commented 1 year ago

Looks good in master. Thanks!

jonathanolson commented 1 year ago

Please close after verifying!

Nancy-Salpepi commented 1 year ago

Looks good in rc.2. Closing