phetsims / molecule-shapes

"Molecule Shapes" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/molecule-shapes
GNU General Public License v3.0
5 stars 6 forks source link

Molecule Shapes and Molecule Shapes: Basics need a maintenance release #252

Closed liammulh closed 1 year ago

liammulh commented 1 year ago

@oliver-phet re-opened https://github.com/phetsims/rosetta/issues/390:

@liammulh the zh_TW translator is still seeing the same issue on 3 sims: Masses and Springs: Basics Molecule Shapes: Basics Molecule Shapes

All 3 seem to have 2 shared strings that aren't available to translate, but are included in the info statistics (all strings are translated). Screenshot_20230408_081345

Molecule Shapes doesn't have shared strings. The problem is that there are empty strings in Molecule Shapes and Molecule Shapes: Basics — geometry.empty and shape.empty. These aren't presented to the user for translation, and they aren't counted in the translation statistics.

For more info on the decision to not present empty strings to users, see https://github.com/phetsims/rosetta/issues/388.

jbphet commented 1 year ago

I've done a maintenance release of the Molecule Shapes sims, and @liammulh restarted Rosetta, and things are looking good now:

image

jbphet commented 1 year ago

The maintenance release is complete, but I wanted to transfer the issue from rosetta to molecule-shapes because that seems like a more reasonable place for it if we ever need to find it. The parent issue - https://github.com/phetsims/rosetta/issues/388 - is still in the rosetta repo.

jbphet commented 1 year ago

This is done - closing.