search

phetsims / molecules-and-light

"Molecules and Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 5 forks source link

Move Reset Molecule button to under the Photon Rate slider's Help Text #290

Closed terracoda closed 4 years ago

terracoda commented 4 years ago

In #280 we moved the button and in #265 we are renaming it. This little button is a tricky one.

let's try once again placing it in the PDOM after the Photon Rate slider:

Sample Pseudo Code: H3: Observation Window ‪ UL Li: O2 and O out of view. Reset molecule to make more observations.

INPUT type range: Ultraviolet Photon Rate, slider P for Help text (for slider): Set photon emission rate.

Button: Reset Molecule

Note in the A11y View, the aria-valuetext for the slider value should come before the Reset Molecule button.

jessegreenberg commented 4 years ago

Done in the above commit image

in the A11y View, the aria-valuetext for the slider value should come before the Reset Molecule button.

This is a general issue with aria-valuetext and the a11y-view. Ill make an issue in chipper, if there isn't one already.

terracoda commented 4 years ago

@jessegreenberg, maybe it is time to think about how we could put Object Responses like current aria-valuetext over above the Context Responses, or interwoven with the the Context responses?

jessegreenberg commented 4 years ago

Interesting! I moved your comment to https://github.com/phetsims/chipper/issues/896 since we work on this more generally there. Closing this issue.