Reset Molecule button not working

phetsims / molecules-and-light

"Molecules and Light" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 5 forks source link

Reset Molecule button not working #305

Closed terracoda closed 4 years ago

terracoda commented 4 years ago

@jessegreenberg, the Reset Molecule button is not currently operational with mouse or keyboard. Please have a look.

terracoda commented 4 years ago

I looks pressed, so you might have the pressed states reversed.

terracoda commented 4 years ago

Actually, there seems to be a lot issues with the other buttons. Some I can operate with mouse and some I can't.

It seems I can't use the mouse on the Play, Pause, or Step Forward buttons, and the Global Sound button is also not operable by mouse. Something weird is going on with the buttons.

jessegreenberg commented 4 years ago

I just pulled master and I am not seeing any issues with buttons, including the "Reset Molecule" button. @terracoda what version are you testing? If you open the developer tools do you see any errors?

terracoda commented 4 years ago

Good idea! I'll pull master. I haven't pulled since this morning.

terracoda commented 4 years ago

Still having issues... Could be performance related. The Reset Molecule didn't work with mouse or keyboard. The other buttons worked for a bit, then stopped working and Voice Over was saying, "Safari Busy"

No buttons were working once Safari became busy.

terracoda commented 4 years ago

Using MacOs 10.13.6, Voice Over and Safari

jessegreenberg commented 4 years ago

THanks @terracoda OK ill take a look at that platform

jessegreenberg commented 4 years ago

Using macOS 10.15 with and without VoiceOver I am still not seeing this issue. @terracoda is this still happening for you?

terracoda commented 4 years ago

Yep. Here's a screen shot of a pressed button and no molecule:

jessegreenberg commented 4 years ago

OK should be fixed in the above commit, @terracoda can you please make sure I got it?

terracoda commented 4 years ago

I verified the fix @jessegreenberg. Nice work! Closing.