My Solar System code review checklist

[AgustinVallejo]

To begin a code review:

• Copy this checklist to a GitHub issue titled "Code Review" and labeled dev:code-review.
• Delete the Table of Contents section, since the links will be incorrect.
• Delete items and sections that are not relevant.
• Replace https://github.com/phetsims/my-solar-system/issues/ with links to GitHub issues.
• Fill in (or delete) the Specific Instructions section.

---

PhET Code-Review Checklist (a.k.a "CRC")

• The responsible dev is responsible for removing the irrelevant parts
• A checked-off item doesn't mean "no problem here", it means "it was reviewed"
• Problems can be noted in side issues that reference this issue, or through // REVIEW comments in the code

Specific Instructions

Provide specific instructions here. For example: known problems that will fail CRC items, files that can be skipped, code that is not completed, shared or common code that also needs to be reviewed,... If there are no specific instructions, then delete this section.

GitHub Issues

The following standard GitHub issues should exist. If these issues are missing, or have not been completed, pause code review until the issues have been created and addressed by the responsible dev.

• [x] model.md, see https://github.com/phetsims/my-solar-system/issues/96. Familiarize yourself with the model by reading model.md. Does it adequately describe the model, in terms appropriate for teachers? Has it been reviewed by the sim designer?
• [x] implementation-notes.md, see https://github.com/phetsims/my-solar-system/issues/97. Familiarize yourself with the implementation by reading implementation-notes.md. Does it provide an overview that will be useful to future maintainers?
• [x] results of memory testing for brands=phet, see https://github.com/phetsims/my-solar-system/issues/98
• [x] performance testing and sign-off, see https://github.com/phetsims/my-solar-system/issues/99
• [x] review of pointer areas, see https://github.com/phetsims/my-solar-system/issues/100
• [x] credits (will not be completed until after RC testing), see https://github.com/phetsims/my-solar-system/issues/101

Build and Run Checks

If any of these items fail, pause code review.

• [x] Does the sim build without warnings or errors?
• [x] Does the html file size seem reasonable, compared to other similar sims?
• [x] Does the sim start up? (unbuilt and built versions)
• [x] Does the sim experience any assertion failures? (run with query parameter ea)
• [x] Does the sim pass a scenery fuzz test? (run with query parameters fuzz&ea)
• [x] Does the sim behave correctly when listener order is shuffled? (run with query parameters ea&shuffleListeners and ea&shuffleListeners&fuzz)
• [x] Does the sim output any deprecation warnings? Run with ?deprecationWarnings. Do not use deprecated methods in new code.

Memory Leaks

• [x] Does a heap comparison using Chrome Developer Tools indicate a memory leak? (This process is described here.) Test on a version built using grunt --minify.mangle=false. Compare to testing results done by the responsible developer. Results can be found in https://github.com/phetsims/my-solar-system/issues/.
• [x] For each common-code component (sun, scenery-phet, vegas, …) that opaquely registers observers or listeners, is there a call to that component’s dispose function, or is it obvious why it isn't necessary, or is there documentation about why dispose isn't called? An example of why no call to dispose is needed is if the component is used in a ScreenView that would never be removed from the scene graph. Note that it's also acceptable (and encouraged!) to describe what needs to be disposed in implementation-notes.md.
• [x] Are there leaks due to registering observers or listeners? The following guidelines should be followed unless documentation (in-line or in implementation-notes.md) describes why following them is not necessary.
  • AXON: Property.link or lazyLink is accompanied by unlink.
  • AXON: Multilink.multilink is accompanied by unmultilink.
  • AXON: Creation of Multilink is accompanied by dispose.
  • AXON: Creation of DerivedProperty is accompanied by dispose.
  • AXON: Emitter.addListener is accompanied by removeListener.
  • AXON: ObservableArrayDef.element*Emitter.addListener is accompanied by ObservableArrayDef.element*Emitter.removeListener
  • SCENERY: Node.addInputListener is accompanied by removeInputListener
  • TANDEM: Creation of an instrumented PhetioObject is accompanied by dispose.
• [x] Do all types that require a dispose function have one? This should expose a public dispose function that calls this.disposeMyType(), where disposeMyType is a private function declared in the constructor. MyType should exactly match the filename.

Performance

• [x] Play with sim, identify any obvious performance issues. Examples: animation that slows down with large numbers of objects; animation that pauses or "hitches" during garbage collection.
• [x] If the sim uses WebGL, does it have a fallback? Does the fallback perform reasonably well? (run with query parameter webgl=false)

Usability

• [x] Are UI components sufficiently responsive? (especially continuous UI components, such as sliders)
• [x] Are pointer areas optimized, especially for touch? (run with query parameter showPointerAreas)
• [x] Do pointer areas overlap? (run with query parameter showPointerAreas) Overlap may be OK in some cases, depending on the z-ordering (if the front-most object is supposed to occlude pointer areas) and whether objects can be moved.

Internationalization

• [x] Are there any strings that are not internationalized, and does the sim layout gracefully handle internationalized strings that are shorter than the English strings? (run with query parameter stringTest=X. You should see nothing but 'X' strings.)
• [x] Does the sim layout gracefully handle internationalized strings that are longer than the English strings? (run with query parameters stringTest=double and stringTest=long)
• [x] Does the sim stay on the sim page (doesn't redirect to an external page) when running with the query parameter stringTest=xss? This test passes if sim does not redirect, OK if sim crashes or fails to fully start. Only test on one desktop platform. For PhET-iO sims, additionally test ?stringTest=xss in Studio to make sure i18n strings didn't leak to phetioDocumentation, see https://github.com/phetsims/phet-io/issues/1377
• [x] Avoid using concatenation to create strings that will be visible in the user interface. Use StringUtils.fillIn and a string pattern to ensure that strings are properly localized.
• [x] Use named placeholders (e.g. "{{value}} {{units}}") instead of numbered placeholders (e.g. "{0} {1}").

• [x] Make sure the string keys are all perfect, because they are difficult to change after 1.0.0 is published. Guidelines for string keys are:

  (1) Strings keys should generally match their values. E.g.:

  "helloWorld": {
  value: "Hello World!"
  },
  "quadraticTerms": {
  value: "Quadratic Terms"
  }

  (2) If a string key would be exceptionally long, use a key name that is an abbreviated form of the string value, or that captures the purpose/essence of the value. E.g.:

  // key is abbreviated
  "iWentToTheStore": {
  value: "I went to the store to get milk, eggs, butter, and sugar."
  },
  
  // key is based on purpose
  "describeTheScreen": {
  value: "The Play Area is a small room. The Control Panel has buttons, a checkbox, and radio buttons to change conditions in the room."
  }

  (3) If string key names would collide, use your judgment to disambiguate. E.g.:

  "simplifyTitle": {
   value: "Simplify!"
  },
  "simplifyCheckbox": {
   value: "simplify"
  }

  (4) String keys for screen names should have the general form "screen.{{screenName}}". E.g.:

  "screen.explore": {
    "value": "Explore"
  },

  (5) String patterns that contain placeholders (e.g. "My name is {{first}} {{last}}") should use keys that are unlikely to conflict with strings that might be needed in the future. For example, for "{{price}}" consider using key "pricePattern" instead of "price", if you think there might be a future need for a "price" string. (6) It is acceptable to prefix families of strings with a prefix, like so:

  "material.water": {
    "value": "Water"
  },
  "material.wood": {
    "value": "Wood"
  },
  "shape.block": {
    "value": "Block"
  },
  "shape.cone": {
    "value": "Cone"
  },

Nested substructure is not yet fully supported.

• [x] If the sim was already released, make sure none of the original string keys have changed. If they have changed, make sure any changes have a good reason and have been discussed with @jbphet (it is likely that an issue like https://github.com/phetsims/gravity-force-lab/issues/166 should be created).

Repository Structure

• [x] The repository name should correspond to the sim title. For example, if the sim title is "Wave Interference", then the repository name should be "wave-interference".

• [x] Are all required files and directories present? For a sim repository named “my-repo”, the general structure should look like this (where assets/, images/, mipmaps/ or sounds/ may be omitted if the sim doesn’t have those types of resource files).

  my-repo/
  assets/
  doc/
    images/
      *see annotation
    model.md
    implementation-notes.md
  images/
    license.json
  js/
    (see section below)
  mipmaps/
    license.json
  sound/
    license.json
  dependencies.json
  .gitignore
  my-repo_en.html
  my-repo-strings_en.json
  Gruntfile.js
  LICENSE
  package.json
  README.md

  *Any images used in model.md or implementation-notes.md should be added here. Images specific to aiding with documentation do not need their own license.

• [x] Verify that the same image file is not present in both images/ and mipmaps/. If you need a mipmap, use it for all occurrences of the image.

• [x] Is the js/ directory properly structured? All JavaScript source should be in the js/ directory. There should be a subdirectory for each screen (this also applies for single-screen sims, where the subdirectory matches the repo name). For a multi-screen sim, code shared by 2 or more screens should be in a js/common/ subdirectory. Model and view code should be in model/ and view/ subdirectories for each screen and common/. For example, for a sim with screens “Introduction” and “Lab”, the general directory structure should look like this:

  my-repo/
  js/
  common/
    model/
    view/
  introduction/
    model/
    view/
  lab/
    model/
    view/
  my-repo-main.js
  myRepo.js
  myRepoStrings.js

• [x] Do filenames use an appropriate prefix? Some filenames may be prefixed with the repository name, e.g. MolarityConstants.js in molarity. If the repository name is long, the developer may choose to abbreviate the repository name, e.g. EEConstants.js in expression-exchange. If the abbreviation is already used by another repository, then the full name must be used. For example, if the "EE" abbreviation is already used by expression-exchange, then it should not be used in equality-explorer. Whichever convention is used, it should be used consistently within a repository - don't mix abbreviations and full names.

• [x] Is there a file in assets/ for every resource file in sound/ and images/? Note that there is not necessarily a 1:1 correspondence between asset and resource files; for example, several related images may be in the same .ai file. Check license.json for possible documentation of why some resources might not have a corresponding asset file.

• [x] For simulations, was the README.md generated by grunt published-README or grunt unpublished-README? Common code repos can have custom README files.

• [x] Does package.json refer to any dependencies that are not used by the sim?

• [x] Is the LICENSE file correct? (Generally GPL v3 for sims and MIT for common code, see this thread for additional information).

• [x] Does .gitignore match the one in simula-rasa?

• [x] In GitHub, verify that all non-release branches have an associated issue that describes their purpose.

• [x] Are there any GitHub branches that are no longer needed and should be deleted?

• [x] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ ( if there is no common/). The .js file should be named {{PREFIX}}QueryParameters.js, for example ArithmeticQueryParameters.js for the arithmetic repository, or FBQueryParameters.js for Function Builder (where the FB prefix is used).

• [x] Query parameters that are public-facing should be identified using public: true in the schema.

• [x] All sims should use a color file named MyRepoColors.js or, if using abbreviations, MRColors.js, and use ProfileColorProperty where appropriate, even if they have a single (default) profile (to support color editing and PhET-iO Studio). The ColorProfile pattern was converted to *Colors.js files in https://github.com/phetsims/scenery-phet/issues/515. Please see GasPropertiesColors.js for a good example.

Coding Conventions

• [x] Are coding conventions outlined in PhET's Coding Conventions Document followed and adhered to? This document deals with PhET coding conventions. You do not need to exhaustively check every item in this section, nor do you necessarily need to check these items one at a time. The goal is to determine whether the code generally meets PhET standards.

TypeScript Conventions

• [x] Are TypeScript conventions outlined in the TypeScript Conventions Document followed and adhered to?

Math Libraries

• [x] DOT/Utils.toFixed or DOT/Utils.toFixedNumber should be used instead of toFixed. JavaScript's toFixed is notoriously buggy. Behavior differs depending on browser, because the spec doesn't specify whether to round or floor.

IE11

• [x] IE is no longer supported. With that in mind remove IE-specific workarounds
• [x] Use string.includes and string.startsWith where possible.

Organization, Readability, and Maintainability

• [x] Does the organization and structure of the code make sense? Do the model and view contain types that you would expect (or guess!) by looking at the sim? Do the names of things correspond to the names that you see in the user interface?
• [x] Are appropriate design patterns used? See phet-software-design-patterns.md. If new or inappropriate patterns are identified, create an issue.
• [x] Is inheritance used where appropriate? Does the type hierarchy make sense?
• [x] Is composition favored over inheritance where appropriate? See https://en.wikipedia.org/wiki/Composition_over_inheritance.
• [x] Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions). In TypeScript, you can decouple by narrowing the API like so:

  public constructor( tickMarksVisibleProperty: Property<boolean>,
                    model: Pick<IntroModel, 'changeWaterLevel'>, // <-- Note the call site can pass the whole model, but we declare we will only use this part of it
                    waterCup: WaterCup, modelViewTransform: ModelViewTransform2,
                    providedOptions?: WaterCup3DNodeOptions ) {

• [x] Is there too much unnecessary decoupling? (e.g. by passing all of the properties of an object independently instead of passing the object itself)?
• [x] Are the source files reasonable in size? Scrutinize large files with too many responsibilities - can responsibilities be broken into smaller delegates?
• [x] Are any significant chunks of code duplicated? In addition to manual identification, tools include: WebStorm Code > Analyze Code > Locate Duplicates and https://github.com/danielstjules/jsinspect.
• [x] Is there anything that should be generalized and migrated to common code?
• [x] Are there any TODO or FIXME or REVIEW comments in the code? They should be addressed or promoted to GitHub issues.
• [x] Are there any magic numbers that should be factored out as constants and documented?
• [x] Are there any constants that are duplicated in multiple files that should be factored out into a {{REPO}}Constants.js file?
• [x] Does the implementation rely on any specific constant values that are likely to change in the future? Identify constants that might be changed in the future. (Use your judgement about which constants are likely candidates.) Does changing the values of these constants break the sim? For example, see https://github.com/phetsims/plinko-probability/issues/84.
• [x] Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in PhetColorScheme. Identify any colors that might be worth adding to PhetColorScheme.
• [x] Are all dependent Properties modeled as DerivedProperty instead of Property?
• [x] All dynamics should be called from Sim.step(dt), do not use window.setTimeout or window.setInterval. This will help support Legends of Learning and PhET-iO.

Accessibility

This section may be omitted if the sim has not been instrumented with accessibility features. Accessibility includes various features, not all are always include. Ignore sections that do not apply.

General

• [x] Are accessibility features integrated well into the code. They should be added in a maintainable way, even if that requires upfront refactoring.

Alternative Input

• [x] Does the sim pass an accessibility fuzz test? (run with query parameters fuzzBoard&ea)
• [x] Does this sim use specific keyboard shortcuts that overlap with global shortcuts? This includes the use of modifier keys like in https://github.com/phetsims/ratio-and-proportion/issues/287. NOTE: There is currently no list of global shortcuts, and therefore no way to complete this checklist item. See https://github.com/phetsims/phet-info/issues/188.

Interactive Description

• [x] Run the entire built sim HTML file through an HTML validator, does the HTML pass?
• [x] If applicable, are good design patterns used for interactive description, see interactive-description-technical-guide.md
• [x] Does resetting the simulation also reset the entire PDOM?
• [x] Is Node.pdomOrder used appropriately to maintain visual and PDOM layout balance?
• [x] Make sure accessibility strings aren't being adjusted with ascii specific javascript methods like toUpperCase(). Remember that one day these strings will be translatable
• [x] Make sure for accessibility strings that all end of sentence periods do not have a leading space before it. Some screen readers will read these as "dot." This can occur often when a clause is conditionally added.

[jonathanolson]

After the above 9 commits, it looks like the sim in master is currently free of memory leaks.

[jonathanolson]

@AgustinVallejo I've started adding additional REVIEW notes (might make sense to start handling those). Assigning.

[jonathanolson]

@AgustinVallejo can you create the issues mentioned in the first section?

[AgustinVallejo]

@jonathanolson Added the issues, thanks

[jonathanolson]

Main code review complete. @zepumph would you be able to assist with the interactive description review (or help me do so), as I feel like I need more background knowledge to do so.

[samreid]

I'm planning to work on a few of the REVIEW comments in the code. I'll reference this issue in the commits so the changes can be easily checked.

[samreid]

It seems important for @AgustinVallejo to review my changes carefully, since many are around conventions/styles/patterns that would be good to use in future development.

[AgustinVallejo]

Everything is checked out and ready! Thanks everyone