Closed pixelzoom closed 4 years ago
Fixed in above commit, using nested option pathOptions
for the Path subcomponent of VerticalLines.
@jonathanolson please review.
I'll be taking shas for the 1.2 branch on 9/17, and this needs to be reviewed before then. So high priority please.
Looks great to me, thanks!
Related to #203 (code review) @jonathanolson had this REVIEW comment about PopulationGridNode.VerticalLines:
Good catch, this is not what I intended here. Passing all options to a subcomponent is (imo) an anti-pattern. And clipArea makes it worse here. I will address, probably via nested options for the Path.