search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Typo in client-requests.md #241

Closed amanda-phet closed 4 years ago

amanda-phet commented 4 years ago

@loganbraywork found a typo in client-requests.md.

Where it says naturalSelection.introScreen.view.addMutationsPanel.teethsRow.visibleProperty it should say naturalSelection.introScreen.view.addMutationsPanel.teethRow.visibleProperty.

This will need to be branched and patched.

amanda-phet commented 4 years ago

I made the update.

Over to you @pixelzoom

pixelzoom commented 4 years ago

Note to self: I need to create branch "natural-selection-1.2" of phet-io-client-guides, then cherry-pick 7323b2abc1dfd52a1b77aa020de7ec3c7e7ce414 to that branch.

pixelzoom commented 4 years ago

Patched and tested in the 1.2 branch. Ready for testing in the next 1.2 RC.

Verify on 1 platform using these steps:

  1. Go to the wrapper index
  2. Click on the "Client Requests" link
  3. In the document that opens, verify that:
    • naturalSelection.introScreen.view.addMutationsPanel.teethsRow.visibleProperty is NOT present
    • naturalSelection.introScreen.view.addMutationsPanel.teethRow.visibleProperty IS present
phet-steele commented 4 years ago

While testing 1.2.0-rc.2, I found 0 instances of naturalSelection.introScreen.view.addMutationsPanel.teethsRow.visibleProperty in the client request guide, and 1 instance of naturalSelection.introScreen.view.addMutationsPanel.teethRow.visibleProperty. Closing.