search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Missing updates in Client Guides #268

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/QA/issues/636. In client requests there is a request to hide the generation clock. But the instructions provided do not match anything in studio.

notinstudio
KatieWoe commented 3 years ago

This also seems to happen for hiding the environmental buttons

visiblenotinstudio
pixelzoom commented 3 years ago

Good catch.

It looks like files in phet-io-client-guides/natural-selection were not updated after adding environmentPanel to the tandem hierachy for for https://github.com/phetsims/natural-selection/issues/263.

I've fixed client-requests.md in the above commits (@amanda-phet please review), and the revised tandems are:

naturalSelection.introScreen.view.environmentPanel.generationClockNode.visibleProperty naturalSelection.labScreen.view.environmentPanel.generationClockNode.visibleProperty naturalSelection.introScreen.view.environmentPanel.environmentRadioButtonGroup.visibleProperty naturalSelection.labScreen.view.environmentPanel.environmentRadioButtonGroup.visibleProperty

It also looks like linked-property-example.png and studio-overview.png need to be revised, since they show the part of the Studio treee that has changed. I can't revise them because the assets used to create them are not checked in. (That appears to be general problem with all client guides, so I've created https://github.com/phetsims/phet-io-client-guides/issues/10 to resolve that.) @amanda-phet can you please revise these images with top priority? (This is blocking the PhET-iO team from commiting some work to master.)

amanda-phet commented 3 years ago

I created these updated assets. If it's ok for me to commit them to master I can do that, but I wasn't sure so just putting them here for @pixelzoom.

linked-property-example

studio-overview
amanda-phet commented 3 years ago

I see the revised tandems as well.

pixelzoom commented 3 years ago

@amanda-phet The files that you've included in https://github.com/phetsims/natural-selection/issues/268#issuecomment-818987577 have totally different than the dimensions of the files in GitHub. Their resolution is significantly lower. Does that matter?

linked-property-example.png is 2880 x 1578, yours is 1531 x 840. studio-overview.png is in the ballpark of 2720 x 1084 yours is 1872 x 752.

pixelzoom commented 3 years ago

@amanda-phet sent me another set of PNG files via Slack. The resolution is higher, but the dimensions are still off. She checked with @arouinfar, and "there is no scientific process for creating the screenshots". So we decided to go with these files, and I've commited them above.

I tested by doing a local build, then inspecting the "PhET-iO Guide" and "Client Requests" links in the Wrapper Index. I didn't see any problems.

I'll labeled this a ready for QA verification.

pixelzoom commented 3 years ago

To verify this issue:

KatieWoe commented 3 years ago

Looks good in rc.1